Fix pylint warnings / cleanup #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
ddelange
added a commit
to ddelange/psutil
that referenced
this pull request
Apr 11, 2023
* 'master' of https://github.com/giampaolo/psutil: move psutil_getpagesize() in a new mem.c file move psutil_virtual_mem() in a new mem.c file update cpu_freq() doc Fix Linux test: allow '-dirty' or other version postfixes (giampaolo#2221) Fix pylint warnings / cleanup (giampaolo#2218) Makefile: define num CPUs for parallel workers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
make pylinttarget to run pylint against the code base. I don't want to make pylint mandatory. Don't want to run it on commit/push and reject commits, since pylint is waaaay too strict. This is just meant to be used manually from time to time. Nevertheless, running it against the whole code base for the first time revealed many places which were worth being refactored.