Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for /trunk/psutil/_psposix.py #352

Closed
giampaolo opened this issue May 23, 2014 · 3 comments
Closed

Patch for /trunk/psutil/_psposix.py #352

giampaolo opened this issue May 23, 2014 · 3 comments

Comments

@giampaolo
Copy link
Owner

From dbon...@gmail.com on February 21, 2013 22:43:33

don't blow up if pid_exists is passed a long for a pid

Attachment: _psposix.py.patch

Original issue: http://code.google.com/p/psutil/issues/detail?id=352

@giampaolo
Copy link
Owner Author

From g.rodola on February 21, 2013 20:39:14

That check is actually unnecessary because of what comes next: 
https://code.google.com/p/psutil/source/browse/trunk/psutil/_psposix.py?spec=svn1562&r=1551#22
 If something different than a number is passed "if pid < 0:" will 
automatically raise TypeError on python 3 and os.kill() will do the same on 
both python 2 and 3:

>>> os.kill('x', 0)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: an integer is required
>>> 

Thanks anyway.

Status: WontFix

@giampaolo
Copy link
Owner Author

From g.rodola on February 21, 2013 21:02:01

See r1563 .

@giampaolo
Copy link
Owner Author

From g.rodola on March 02, 2013 04:14:18

Updated csets after the SVN -> Mercurial migration: r1563 == revision 
70d73524a81b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant