Test fixes #681
Merged
Test fixes #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 6, 2015 01:06
Replacing psutil.cpu_count affects other tests. Calling the "parent function" will test this better.
…sible Some environments don't support running 'python' outside of its directory. There is already a test that compiles an executable for testing - so we use that code if possible, and fall back to copying the Python executable only if gcc isn't available. This also allows test_prog_w_funky_name to be tested on Winows, where moving the executable is ok (at least for default Python distributions).
In POSIX systems, process name from psinfo is limited to 15 chars. There can be a unicode character cut off in position 15 and then Py_BuildValue will fail to parse the name as UTF-8 (Python 3 only). This needs to be addressed but for now avoid it in the tests
|
|
||
| @classmethod | ||
| def tearDownClass(cls): | ||
| if not APPVEYOR: |
There was a problem hiding this comment.
mmm this was needed because on APPVEYOR sometimes you get "can't delete file used by another process" errors - I would revert this change
|
I reversed the change you asked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes to tests that failed on our environments. I described in the commits what needed fixing.