Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redundant check in WinXp implementation of psutil_get_open_files #725

Closed
mezrin opened this issue Jan 11, 2016 · 2 comments
Closed

redundant check in WinXp implementation of psutil_get_open_files #725

mezrin opened this issue Jan 11, 2016 · 2 comments
Labels
windows

Comments

@mezrin
Copy link

mezrin commented Jan 11, 2016

https://github.com/giampaolo/psutil/blob/master/psutil/arch/windows/process_handles.c#L356

__NtQueryObject does not used by WinXP implementation of psutil_get_open_files
So check __NtQueryObject == NULL is redundant and should be deleted
@giampaolo
Copy link
Owner

Are you saying that the check is there only for Windows XP and since Windows XP is no longer supported it should be removed?

@giampaolo
Copy link
Owner

Closing this out because of inactivity and because it doesn't look too important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giampaolo @mezrin