Fixed bug in NetBSD's execution of virtual_memory() #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtual_memory() opened the /proc/meminfo file as a binary. As such, each line was a binary, but lines 135 and 137 were checking against a string type. This caused str.startswith() to raise a TypeError and fail. The solution was merely to change the str.startswith() comparison to a binary.
|
NIce, thanks. Please update HISTORY and CREDITS files then this can be merged. |
|
Updated. |
|
Please use 3f96eb7, the commits afterwards are erroneous and I cannot figure out how to remove them. |
|
Any updates on this pull request? |
|
I'm not sure why but the changes you made in ee36c46 are no longer in this PR. This PR as it stands is not right. If you don't know how to fix it perhaps you can make a new one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtual_memory() opened /proc/meminfo as a binary. As such, each line was a binary, but lines 135 and 137 were checking against a string type. This caused str.startswith() to raise a TypeError and fail.
The solution was merely to change the str.startswith() comparison to a binary.