Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NB2winter wheater-applyTypeBConstraint() function #122

Open
maobw12 opened this issue Mar 9, 2024 · 2 comments
Open

NB2winter wheater-applyTypeBConstraint() function #122

maobw12 opened this issue Mar 9, 2024 · 2 comments

Comments

@maobw12
Copy link

maobw12 commented Mar 9, 2024

Greetings! I would like to ask about the NB2 module for winter wheat when the excel sheet for crop-specific-rule has N3b, N4b, N5b, N6b for perennial crops, but in the code ThermalScreening code, the applyTypeBConstraint() function perennial_flag is N and non-perennials is L. Regardless of whether winter wheat is set to perennial or non-perennial, it always prompts a missing N or L parameter undefined, so I've modified the code, and I'll upload a document to illustrate it with my questions, please answer them, thank you very much!
未定义.docx

@NokuzaSezo97
Copy link
Contributor

Hi @maobw12,

Apologies for the late reply. it is concluded that the crop-specific rule for the winter wheat where 'N' notation and 'L' notation is both applied, after discussion with experts, corresponds to hibernation principle. I have to review all this logic whether it should be provided for every crops. At the moment, my suggestions to this are:

  1. Please do not modify the code because 'N' and 'L' notation corresponds to the different cycle periods of temperature data. Even you try to modify to include both notations, the calculated expression of temperature profiles for hibernation period will not be correct.
  2. Please omit out this particular crop-specific rule notation which uses 'N' and 'L' notations.

I will discuss more with our researchers and will follow up with the finalized implementation. Sorry for the trouble.

Sincerely yours,

Swun Wunna Htet

@maobw12
Copy link
Author

maobw12 commented May 15, 2024

Thank you for your answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants