Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gnome 40 #37

Closed
vscsilva opened this issue Mar 25, 2021 · 4 comments
Closed

Add support for Gnome 40 #37

vscsilva opened this issue Mar 25, 2021 · 4 comments

Comments

@vscsilva
Copy link

Title says it all

@nestormarius
Copy link

+1
Please add GNOME 40 support! Thank you!

@slrtbtfs
Copy link

slrtbtfs commented Mar 27, 2021

Currently, when trying to use the extension with Gnome 40, its settings crash with the following stack trace:

Error: No property margin on GtkBox

Stack trace:
  _init/Gtk.Widget.prototype._init@resource:///org/gnome/gjs/modules/core/overrides/Gtk.js:45:40
  make_row_switch@/usr/share/gnome-shell/extensions/gamemode@christian.kellner.me/prefs.js:29:20
  _init@/usr/share/gnome-shell/extensions/gamemode@christian.kellner.me/prefs.js:19:23
  buildPrefsWidget@/usr/share/gnome-shell/extensions/gamemode@christian.kellner.me/prefs.js:111:18
  _init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:209:40
  OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
  asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22
  run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20
  main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
  run@resource:///org/gnome/gjs/modules/script/package.js:206:19
  start@resource:///org/gnome/gjs/modules/script/package.js:190:8
  @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17
  

@pedrofleck
Copy link

For it to work in Gnome 40, any window needs to be updated to Gtk 4.0.

@gicmo
Copy link
Owner

gicmo commented Jun 8, 2021

This should hopefully be fixed with release 5, thanks everyone for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants