Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XOR encryption key too short #71

Closed
AnthonyBall1966 opened this issue Apr 29, 2015 · 5 comments
Closed

XOR encryption key too short #71

AnthonyBall1966 opened this issue Apr 29, 2015 · 5 comments

Comments

@AnthonyBall1966
Copy link
Contributor

The xor encryption key is too short (unless it has been changed recently) as it's only a byte or two longer than some standard fixed headers (the lua bytecode header is one of them). It would be better if set to something 256 bytes or longer.

@hgy29
Copy link
Contributor

hgy29 commented May 6, 2015

Agreed, 256 bytes sequence is a minimum for this kind of encryption, plus sequence shifts/modification along the encrypted file so that repetitions are harder to spot.
Also key location marker in generated file should be overwrited too to make it harder for an attacker to recover the key from the gideros lib itself

@hgy29
Copy link
Contributor

hgy29 commented May 6, 2015

Work in progress to address this :)

@hgy29
Copy link
Contributor

hgy29 commented May 7, 2015

Added encryption scheme enhancement in PR #75, as discussed with @SinisterSoft

@AnthonyBall1966
Copy link
Contributor Author

:)

@ar2rsawseen
Copy link
Member

PR Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants