Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean fields not mapped when using 'is' getter methods instead of 'get' #11

Closed
GoogleCodeExporter opened this issue Apr 14, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Steps to reproduce: Run the attached unit test.

From what I gather this is a bug in one of the JDK introspector classes - 
java.beans.PropertyDescriptor.getReadMethod - which in 1.5.0 recognizes 'is' 
getters only for boolean types (forgetting its big brother - Boolean).

It would be nice if Orika included some sort of workaround for this issue. 

Original issue reported on code.google.com by lighteater on 29 Mar 2012 at 1:20

Attachments:

@GoogleCodeExporter
Copy link
Author

the convention is "get" for Boolean and not "is", only primitive boolean has 
"is",
in the 1.1 we can extend the default propertyResolvingStrategy to lookup for 
accessors and mutators other than Introspector's getter and setter

Original comment by elaat...@gmail.com on 29 Mar 2012 at 11:32

@GoogleCodeExporter
Copy link
Author

Oh, I didn't realize that. 
Either way this becomes a problem when dealing with some tools that don't 
respect this convention. xjc is a good example of that, the classes it 
generates by default break this rule. 

Thanks.

Original comment by lighteater on 30 Mar 2012 at 11:23

@GoogleCodeExporter
Copy link
Author

Done in the 1.1.0

Original comment by elaat...@gmail.com on 20 Apr 2012 at 2:59

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant