Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Path must be a string" error if there's no tmp dir in env #86

Closed
cheeaun opened this issue Jan 11, 2017 · 2 comments
Closed

"Path must be a string" error if there's no tmp dir in env #86

cheeaun opened this issue Jan 11, 2017 · 2 comments
Assignees

Comments

@cheeaun
Copy link

cheeaun commented Jan 11, 2017

Regarding the latest change here: 494e723#diff-f16acefe4b6553580c43edab685f50f3R87

In my case process.env.TMPDIR || process.env.npm_config_tmp returns an undefined value which causes a Path must be a string error when the value is passed into path.join method here:

var candidatePath = path.join(candidateTmpDirs[i], 'chromedriver');

I can open a PR but not sure what's a good "fallback" value, probably process.env.TMPDIR || process.env.npm_config_tmp || ''?

@giggio giggio closed this as completed in 1c7fb6f Jan 11, 2017
@giggio
Copy link
Owner

giggio commented Jan 11, 2017

Fixed and published now as 2.27.2.

@giggio giggio self-assigned this Jan 11, 2017
@lock
Copy link

lock bot commented Jul 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants