Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo request #33

Closed
itscz-org opened this issue Jan 25, 2018 · 6 comments
Closed

Undo request #33

itscz-org opened this issue Jan 25, 2018 · 6 comments

Comments

@itscz-org
Copy link

I am asking for undoing this commit: fddd481

The problem there relies on unbeautiness in Uruguay and Argentina borders and some waters - that change dramatically increase rendering times between z0 and z6, in my case the z0 render time increased from 0.155s to 370.529s - that is 2390x slower.

I don't know if we need this slow-down change in a german style. Please re-consider the pull request.

@giggls
Copy link
Owner

giggls commented Jan 25, 2018

Did you report this upstream? In openstreetmap-carto-de this is just a merge from upstream carto.

@itscz-org
Copy link
Author

I commented the original pull request: gravitystorm#2873

@giggls
Copy link
Owner

giggls commented Jan 25, 2018

I'm aware of the problem and would have like to see something along the line of Christophs suggestions: http://blog.imagico.de/parting-the-waters/
My Problem in German style is that I have to be close enough to standard style to allow for reasonably easy merging.

@kocio-pl
Copy link

gravitystorm#2507 is probably how it should be done, but no participant of this discussion is currently active in osm-carto and nobody answered when I asked there, so I don't know what's the plan at the moment. Maybe you could just talk with them directly.

@giggls
Copy link
Owner

giggls commented Jan 27, 2018

@it-solutions-zehaczek: I merged the work from @imagico (Low Zoom waterbodies and water instead of land polygons) into dev-de branch. I will likely also merge this into my master branch. You might give this a try.

@itscz-org
Copy link
Author

Ok thx, i'll check this out within the next days.

@giggls giggls closed this as completed May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants