Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed not working --output option #31

Merged
merged 1 commit into from Sep 9, 2018

Conversation

r-plus
Copy link
Contributor

@r-plus r-plus commented Sep 9, 2018

Fixed --output option is not working correctly.
--output option passed as output option, but JSONReporter required output_path option.

This is not breaking change to users that using JSONReporter from ruby.
I also make breaking change version of branch r-plus@d987723 that rename to output from output_path which do you like?

$ ./bin/xcprofiler spec/fixtures/MyApp-xxxxxxxxxxx/Logs/Build/valid.xcactivitylog -l 1 -t 10 --output hoge.json
+-------------------+------+-------------+----------+
| File              | Line | Method name | Time(ms) |
+-------------------+------+-------------+----------+
| Interaction.swift | 17   | get {}      | 69.9     |
+-------------------+------+-------------+----------+
[JSONReporter] output_path is not specified

Copy link
Owner

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I should write tests for the command line interface 😅

Thanks!

@giginet giginet merged commit cd1234d into giginet:master Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants