Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

changed method to methods and added args #13

Closed
wants to merge 1 commit into from

Conversation

esteininger
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests (if applicable)?
  2. Have you lint your code locally prior to submission (use flake8)?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@gijswobben
Copy link
Owner

Hi Ethan,
Thanks for contributing! I hope you don't mind but I've rewritten the code of your pull requests a bit. I saw, for example, that you use .find instead of .findall, which means you're missing part of the abstracts. I also had some request for other fields so I added them in a single pull request.
Kind regards,
Gijs

@gijswobben gijswobben closed this Feb 21, 2019
@esteininger esteininger deleted the patch-2 branch February 21, 2019 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants