-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there any way to tell the component where to create the tour elements instead of it automatically being created at the end of the body? #557
Comments
Hey, |
Stale issue message |
@a-pachkov You can change the |
@gilbarbara Thank you for the replay! |
Now imagine that in a library used by thousands! 😀 |
When to upgrade embedded |
Same issue here.. Would be nice to have a solution for this. |
Hello! I recently discovered this wonderful package and I've just finished implementing a few product tours in my React web application. However, I am now running into an issue with the component when our app is fullscreen and need help finding a solution.
Our React application is designed to be embedded into other webpages. We offer functionality to go into fullscreen mode within our application. When we do this, we don't bring the entire webpage into fullscreen. We take our app's parent container into fullscreen.
I've noticed that the react-joyride elements always get created inside Body before the closing tag. Therefore, if we are in the middle of our tour and the user jumps into fullscreen mode, the joyride elements don't come with us. And similarly, if we are in fullscreen when we initialize the tour, the joyride elements aren't visible because they are not a child of the element we brought into fullscreen.
I looked through the documentation and issues for react-joyride and react-floater to see if this has been addressed already, but I didn't find anything.
Is there an existing way to tell the component where it should create itself? If not, could we add a new prop to react-joyride that accepts a reference or similar of the parent element where we want the react-joyride elements to be created?
Any help or suggestions would be greatly appreciated. Please let me know if there any other information I can provide to help.
The text was updated successfully, but these errors were encountered: