Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any way to tell the component where to create the tour elements instead of it automatically being created at the end of the body? #557

Open
kintz09 opened this issue Nov 14, 2019 · 8 comments

Comments

@kintz09
Copy link

kintz09 commented Nov 14, 2019

Hello! I recently discovered this wonderful package and I've just finished implementing a few product tours in my React web application. However, I am now running into an issue with the component when our app is fullscreen and need help finding a solution.

Our React application is designed to be embedded into other webpages. We offer functionality to go into fullscreen mode within our application. When we do this, we don't bring the entire webpage into fullscreen. We take our app's parent container into fullscreen.

I've noticed that the react-joyride elements always get created inside Body before the closing tag. Therefore, if we are in the middle of our tour and the user jumps into fullscreen mode, the joyride elements don't come with us. And similarly, if we are in fullscreen when we initialize the tour, the joyride elements aren't visible because they are not a child of the element we brought into fullscreen.

I looked through the documentation and issues for react-joyride and react-floater to see if this has been addressed already, but I didn't find anything.

Is there an existing way to tell the component where it should create itself? If not, could we add a new prop to react-joyride that accepts a reference or similar of the parent element where we want the react-joyride elements to be created?

Any help or suggestions would be greatly appreciated. Please let me know if there any other information I can provide to help.

@gilbarbara
Copy link
Owner

Hey,
There's no way to do that right now. I'll need to upgrade react-floater package to support it. I'll work on it when I have some spare time

@github-actions
Copy link

github-actions bot commented Mar 6, 2020

Stale issue message

@a-pachkov
Copy link

Hello! Great library, thank you!
I also running into an issue when red marker try to follow clipped element:
Screen Recording 2020-04-10 at 12 59 PM

And this feature may solve my issue too
Or maybe there exists another way to clip that marker

@gilbarbara
Copy link
Owner

@a-pachkov You can change the z-index to prevent that behavior

@a-pachkov
Copy link

@gilbarbara Thank you for the replay!
Sure I can manage this issue with right z-index on header and horizontal menus
But in this case I'll need to set different z-index for each marker depending on place and clip elements around this place
For example I'll need this marker in header or in pop-up window
So it can add a lot of mess in the code and the pain of maintaining it
But anyway thank you!

@gilbarbara
Copy link
Owner

gilbarbara commented Apr 20, 2020

@a-pachkov

So it can add a lot of mess in the code and the pain of maintaining it

Now imagine that in a library used by thousands! 😀

@Astra-RX
Copy link

When to upgrade embedded react-floater to support this?

@sebass
Copy link

sebass commented Dec 19, 2022

Same issue here.. Would be nice to have a solution for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants