Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting to App Store #184

Closed
alexkitcoff opened this issue Apr 27, 2019 · 7 comments
Closed

Submitting to App Store #184

alexkitcoff opened this issue Apr 27, 2019 · 7 comments

Comments

@alexkitcoff
Copy link

Has anyone tried to submit an app to the App Store using this? It uses UIWebView, which has been deprecated in favor of WKWebView. The App Store Review Guidelines state:

2.5.6 Apps that browse the web must use the appropriate WebKit framework and WebKit Javascript.

@weakfl
Copy link
Contributor

weakfl commented Apr 28, 2019

See #173

@alexkitcoff
Copy link
Author

Thanks for the link. I'm still curious whether people have had success submitting to the App Store using the current version with UIWebView. WebKit doesn't allow JavaScript execution in the background, which kills a lot of the functionality in my app.

@weakfl
Copy link
Contributor

weakfl commented Apr 28, 2019

Since the UIWebView version crashes on iOS 12 it's not really an option anyway.

@alexkitcoff
Copy link
Author

alexkitcoff commented Apr 28, 2019

I have the current version with UIWebView working perfectly fine on iOS 12.2. The reason it crashes in its current state is due to lines 88 and 235 in YouTubePlayer.swift.

public var baseURL = "about:blank"
webView.loadHTMLString(htmlString, baseURL: URL(string: baseURL))

If you delete line 88 and put the baseURL directly in line 235, it works.

webView.loadHTMLString(htmlString, baseURL: URL(string: "about:blank"))

I have no idea why this works, but it does.

@OlegKasarin
Copy link

OlegKasarin commented Oct 5, 2019

I have no idea why this works, but it does.

I have the same crash in example project, because class wasn't initialized from storyboard so baseURL is nil.
URL cannot be initialized with nil. :)

@Jswiizle
Copy link

Any update on this? Considering using this library in my next update.

@gilesvangruisen
Copy link
Owner

Hi @Jswiizle et all, sorry for the delay! The transition to WKWebView is complete, and you can now access the new version 0.7.0 via Carthage or Cocoapods. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants