Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retVal variable pollutes global scope #46

Closed
vsviridov opened this issue Dec 24, 2010 · 3 comments
Closed

retVal variable pollutes global scope #46

vsviridov opened this issue Dec 24, 2010 · 3 comments

Comments

@vsviridov
Copy link

I'm not sure if this is by design, but there's a bunch of places with retVal variable is not prefixed with var, so it ends up in global scope.

Cross-posted from Socket.IO's tracker, since it uses web-socket-js as a shim.

@gimite
Copy link
Owner

gimite commented Dec 24, 2010

I guess it's simply a bug. FABridge is third-party library, so I'm not exactly sure, though.

@gimite
Copy link
Owner

gimite commented Jan 27, 2011

Note that FABridge is external library, so I'd like to keep the change minimum. e.g. I want to keep the original code style, and will fix only obvious bugs such as dropping "var".

@gimite
Copy link
Owner

gimite commented Mar 13, 2011

This bug is now obsolete because we stopped using FABridge.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants