Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gin.Context should use sync.Map #1449

Closed
ajackson-cpi opened this issue Jul 30, 2018 · 4 comments
Closed

gin.Context should use sync.Map #1449

ajackson-cpi opened this issue Jul 30, 2018 · 4 comments

Comments

@ajackson-cpi
Copy link

I'm seeing a "concurrent map" crash where a gin.Context.Copy() product in another goroutine is modifying a key while it's being read elsewhere. context.Context (which is the interface being implemented) will not have a problem with this.

@thinkerou
Copy link
Member

but sync.Map in go1.9 and go1.9+

@himyxia
Copy link

himyxia commented Aug 3, 2018

are there any circumstances that context.Copy() are called by multiple concurrency goroutines ?

@artong0416
Copy link

I have the same problem, is there any good solutions?

@thinkerou
Copy link
Member

thinkerou commented Aug 17, 2018

please see ref #700 #1317 #1335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants