Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
@appleboy @thinkerou @manucorporat
New engine.TrustedProxies feature PR2632 brings breaking changes in many usage case.
PR2692 exports an API to set TrustedProxies but not fix backward compatibility.
We need to make engine.TrustedProxies feature backward-compatible.
The text was updated successfully, but these errors were encountered:
I just wanna say that PR #2632 is crazy, nightmare.
Lots of our apps built on Gin can't be upgraded to the new version of Gin, because all of them will be broken.
Hope this will be fixed soon.
Thanks a lot.
Sorry, something went wrong.
@zihengCat @menduo please help us review #2832 , thanks!
Hi, I think this issue can be closed after #2887 was merged.
closed via #2887
No branches or pull requests