Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TrustedProxies feature backward-compatible #2819

zihengCat opened this issue Aug 13, 2021 · 4 comments

Make TrustedProxies feature backward-compatible #2819

zihengCat opened this issue Aug 13, 2021 · 4 comments


Copy link

zihengCat commented Aug 13, 2021

@appleboy @thinkerou @manucorporat

New engine.TrustedProxies feature PR2632 brings breaking changes in many usage case.

  • RunTLS or run in HTTP handler directly doesn't call prepareTrustedCIDRs.
  • Client IP parsing.

Related issues:

PR2692 exports an API to set TrustedProxies but not fix backward compatibility.

We need to make engine.TrustedProxies feature backward-compatible.

@zihengCat zihengCat changed the title Make engine.TrustedProxies feature backward-compatible Make TrustedProxies feature backward-compatible Aug 13, 2021
Copy link

menduo commented Aug 19, 2021

I agree.

I just wanna say that PR #2632 is crazy, nightmare.

Lots of our apps built on Gin can't be upgraded to the new version of Gin, because all of them will be broken.

Hope this will be fixed soon.

Thanks a lot.

@thinkerou thinkerou added this to the v1.7.5 milestone Aug 20, 2021
Copy link

@zihengCat @menduo please help us review #2832 , thanks!

Copy link

Hi, I think this issue can be closed after #2887 was merged.

Copy link

appleboy commented Oct 6, 2021

closed via #2887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

5 participants