Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful Restarts? #296

Closed
pyrossh opened this issue May 21, 2015 · 7 comments
Closed

Graceful Restarts? #296

pyrossh opened this issue May 21, 2015 · 7 comments

Comments

@pyrossh
Copy link

pyrossh commented May 21, 2015

How about integrating zero downtime restarts in gin server? Maybe using endless?

https://github.com/fvbock/endless

@manucorporat
Copy link
Contributor

Adding a library like that may opens a new world of issues. I am not considering a built-in support for this right now. Even though, I am interested in zero downtime restarts.

If you want to start using endless right now, just do this:

router := gin.Default()
router.GET("/", handler)
// [...]
endless.ListenAndServe(":4242", router)

@elliotlings
Copy link

I don't think it should be included in the library, it may be confusing for people just getting started with the library and may become an issue during development. I'm currently doing what @manucorporat suggested.

@shotcat
Copy link

shotcat commented Feb 21, 2016

good tools is quick my develop speek!

@jacktuck
Copy link

Manners by the folks at BrainTree seems like an alternative to endless 😃

@appleboy
Copy link
Member

@jacktuck Thanks. I already create new PR #561 to update README.

@walleliu1016
Copy link

Adding a library like that may opens a new world of issues. I am not considering a built-in support for this right now. Even though, I am interested in zero downtime restarts.

If you want to start using endless right now, just do this:

router := gin.Default()
router.GET("/", handler)
// [...]
endless.ListenAndServe(":4242", router)

endless not supported under windows platform.

@BlaiseAntony
Copy link

Why not add this functionality in gin lib itself? Do we have any blocker for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants