Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(request): check reader if it's nil before reading #3419

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

noahyao1024
Copy link
Contributor

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@appleboy
Copy link
Member

appleboy commented Dec 1, 2022

@noahyao1024 Please add some testing flow.

@appleboy appleboy added this to the v1.9 milestone Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #3419 (a0ea288) into master (80cd679) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3419      +/-   ##
==========================================
- Coverage   98.27%   98.18%   -0.10%     
==========================================
  Files          42       42              
  Lines        3137     3140       +3     
==========================================
  Hits         3083     3083              
- Misses         40       42       +2     
- Partials       14       15       +1     
Flag Coverage Δ
98.18% <0.00%> (-0.10%) ⬇️
go-1.16 ?
go-1.17 98.08% <0.00%> (-0.10%) ⬇️
go-1.18 98.08% <0.00%> (-0.10%) ⬇️
go-1.19 98.18% <0.00%> (-0.10%) ⬇️
macos-latest 98.08% <0.00%> (-0.19%) ⬇️
ubuntu-latest 98.18% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
context.go 97.47% <0.00%> (-0.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thinkerou thinkerou modified the milestones: v1.9, v1.10 Jan 17, 2023
@appleboy appleboy changed the title Check reader if it's nil before reading chore(request): check reader if it's nil before reading Mar 11, 2024
@appleboy appleboy merged commit ab8042e into gin-gonic:master Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants