Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): fix unit test #3878

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix(engine): fix unit test #3878

merged 2 commits into from
Mar 12, 2024

Conversation

flc1125
Copy link
Contributor

@flc1125 flc1125 commented Mar 11, 2024

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (3dc1cd6) to head (ceb41a4).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3878      +/-   ##
==========================================
- Coverage   99.21%   99.18%   -0.03%     
==========================================
  Files          42       43       +1     
  Lines        3182     2701     -481     
==========================================
- Hits         3157     2679     -478     
+ Misses         17       12       -5     
- Partials        8       10       +2     
Flag Coverage Δ
?
-race ∅ <ø> (?)
-tags "sonic avx" 99.17% <ø> (?)
-tags go_json 99.17% <ø> (?)
-tags nomsgpack 99.17% <ø> (?)
go-1.18 99.11% <ø> (-0.01%) ⬇️
go-1.19 99.18% <ø> (-0.03%) ⬇️
go-1.20 99.18% <ø> (-0.03%) ⬇️
go-1.21 99.18% <ø> (-0.03%) ⬇️
go-1.22 99.18% <ø> (?)
macos-latest 99.18% <ø> (-0.03%) ⬇️
ubuntu-latest 99.18% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flc1125
Copy link
Contributor Author

flc1125 commented Mar 11, 2024

@appleboy What's going on here

@appleboy
Copy link
Member

@flc1125 I will take a look.

@appleboy appleboy added the test label Mar 12, 2024
@appleboy appleboy added this to the v1.10 milestone Mar 12, 2024
@appleboy appleboy merged commit f70dd00 into gin-gonic:master Mar 12, 2024
54 of 55 checks passed
@flc1125 flc1125 deleted the fix-unittest branch March 12, 2024 05:52
@flc1125
Copy link
Contributor Author

flc1125 commented Mar 12, 2024

@flc1125 I will take a look.

Can you tell me what happened?

@appleboy
Copy link
Member

@flc1125 I'm not sure why GitHub Action is unstable, but I just keep restarting the CI/CD flow until all statuses are successful.

@flc1125
Copy link
Contributor Author

flc1125 commented Mar 12, 2024

@flc1125 I'm not sure why GitHub Action is unstable, but I just keep restarting the CI/CD flow until all statuses are successful.

Conjecture: Would it work if we ran runtime.GC() before the unit test?

@appleboy
Copy link
Member

Conjecture: Would it work if we ran runtime.GC() before the unit test?

@flc1125 not sure. Maybe we can try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants