Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not prompt an error when port is occupied! #53

Closed
muei opened this issue Jul 8, 2014 · 6 comments
Closed

Not prompt an error when port is occupied! #53

muei opened this issue Jul 8, 2014 · 6 comments
Assignees
@javierprovecho

Comments

@muei
Copy link

muei commented Jul 8, 2014

test on windows 64!
Not prompt an error when port is occupied!

and if the server is running success, no message .I need to use browser to test whether is success
@javierprovecho
Copy link
Member

When the server starts correctly it will only output log messages. But if it fails to start because of an already bound port, it will close directly. Anyway, I`ll compile for Windows and check how exactly the behaviour is.

@javierprovecho javierprovecho self-assigned this Jul 8, 2014
@manucorporat
Copy link
Contributor

Which version are you using?
Please update to the last version in master.

Run(addr) should panic when http.ListenAndServe() fails.

@manucorporat
Copy link
Contributor

I think this bug was fixed here: 615f199

Can you confirm?

@manucorporat
Copy link
Contributor

You can use go get -u github.com/gin-gonic/gin to update Gin to the latest version or update with git directly.

@muei
Copy link
Author

muei commented Jul 9, 2014

Yeah ,when I update to the latest version,it's correctly.

@manucorporat
Copy link
Contributor

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javierprovecho javierprovecho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@manucorporat @javierprovecho @muei