Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should change package context import directory when go 1.7 #684

Closed
alex023 opened this issue Aug 14, 2016 · 2 comments
Closed

should change package context import directory when go 1.7 #684

alex023 opened this issue Aug 14, 2016 · 2 comments

Comments

@alex023
Copy link

alex023 commented Aug 14, 2016

in context.go ,package context is from "golang.org/x/net"

import"golang.org/x/net/context"

hope can change to:

import "context"

when go 1.7 release.
If can change now, better. Thanks.

@stxml
Copy link

stxml commented Aug 16, 2016

That would break gin for everybody who doesn't have 1.7 already, and it's not even necessary. That import is only used for the interface check and that hasn't changed.

@gdiazlo
Copy link

gdiazlo commented Aug 23, 2016

Keeping up with the latest stable is advisable I think, old repos might disappear or worst, could become incompatible is subtle ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants