Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined: sync.Pool error #72

Closed
taisph opened this issue Jul 16, 2014 · 6 comments
Closed

undefined: sync.Pool error #72

taisph opened this issue Jul 16, 2014 · 6 comments

Comments

@taisph
Copy link

taisph commented Jul 16, 2014

go get github.com/gin-gonic/gin                                                                                                                      
# github.com/gin-gonic/gin
../go/src/github.com/gin-gonic/gin/gin.go:74: undefined: sync.Pool

sync.Pool seems to be introduced in go1.3 meaning gin no longer works with Google App Engine, drone.io and others running go1.2.

Is this intentional?

@manucorporat
Copy link
Contributor

Please check out the app_engine branch.
I hope app-engine supports go1.3 soon...

@seenickcode
Copy link

Hey there @manucorporat, I'm kind of new to Go to please excuse the question but is there any other easier way to "go get" the "app_engine" branch without manually checking it out on my machine?

I'll use net/http for now but I'd really like to use Gin soon if this issue can be fixed.

Thanks,

@manucorporat
Copy link
Contributor

@seenickcode hi, I will test something right now, stay tuned

@taisph
Copy link
Author

taisph commented Sep 7, 2014

app_engine branch is currently broken:

goapp test
# _/home/user/Documents/gin
./context.go:254: undefined: render.Redirect
FAIL    _/home/user/Documents/gin [build failed]

@taisph
Copy link
Author

taisph commented Sep 7, 2014

Seems my fork has been steamrolled by a rebase or something in your app_engine branch. After deleting and re-cloning the error disappeared.

@manucorporat
Copy link
Contributor

Yes, I rebased and forced a push to the remote repo. I know it's not a good practice, but I needed to fix the history in order to be able to merge the changes from develop/master into app_engine easily.

This is not going to happen again! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants