Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tracing-subscriber #31

Merged
merged 5 commits into from Mar 6, 2023

Conversation

ahadnagy
Copy link
Contributor

@ahadnagy ahadnagy commented Mar 5, 2023

This PR provides a tracing_subscriber::Layer implementation for recording log events in applications that use the tracing crate for logging.

@ahadnagy ahadnagy marked this pull request as draft March 5, 2023 22:08
@ahadnagy ahadnagy marked this pull request as ready for review March 5, 2023 22:11
@gin66
Copy link
Owner

gin66 commented Mar 5, 2023

Thanks for the PR. If I understand this correctly, this allows messages from the tracing crate use tui-logger's features.

From my point of view looks good, but I think this feature is better an opt-in.
And actually the slog should be opt-in, too. But I may change this in the next version.

Could you please update ?

@ahadnagy
Copy link
Contributor Author

ahadnagy commented Mar 6, 2023

Thanks for the review!
I made the feature optional.

@gin66 gin66 merged commit 5d26c8f into gin66:master Mar 6, 2023
gin66 added a commit that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants