Update and simplify demo example #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These enums are small and simple enough to be `Copy`. This change simplifies calling code to not have to use `&` when passing or comparing these enums. See https://doc.rust-lang.org/std/marker/trait.Copy.html#when-should-my-type-be-copy for justification. BREAKING CHANGE: `TuiWidgetEvent::transition()` method now takes a `TuiWidgetEvent` by value instead of by reference.
Updated the demo example to use features from the latest version of the `ratatui` crate and simplified the application model significantly. Note that the main crate is still compatible with `ratatui` version `0.25.0`, but the demo example uses features from `0.26.0`. Moved the optional dependencies on `termion` and `crossterm` to the `dev-dependencies` section of the `Cargo.toml` file, and made them mutually exclusive in the demo example. Moved the backend specific code into seperate modules. To run the demo, use either of the following commands: ```shell cargo run --example demo --features crossterm cargo run --example demo --features termion ``` Added a bacon config file to make it easy to check that the demo compiles with the `crossterm` and `termion` features enabled.
Termion
Crossterm
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the demo example to use features from the latest version of the
ratatuicrate and simplified the application model significantly. Notethat the main crate is still compatible with
ratatuiversion0.25.0,but the demo example uses features from
0.26.0.Moved the optional dependencies on
termionandcrosstermto thedev-dependenciessection of theCargo.tomlfile, and made themmutually exclusive in the demo example. Moved the backend specific code
into seperate modules.
To run the demo, use either of the following commands:
Added a bacon config file to make it easy to check that the demo
compiles with the
crosstermandtermionfeatures enabled.Note: includes changes from #55, which is a breaking change that should probably be merged separately this.