Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1953 distance shared #1996

Closed
wants to merge 211 commits into from

Conversation

gbrady92
Copy link
Contributor

Hey Anil and Gina,
I've completed the changes suggested for this insight. These include:

  • The insight is now Twitter only, after looking into the hashtags and the style of posts the apps made on other networks, only Twitter was a suitable network.
  • Because the insight only supports Twitter I removed the code that checked for duplicate posts on different networks.
  • I've changed the language of the copy to be more aimed at encouraging the user to stay active rather than beat records.
  • I've added thresholds which provide the user with different feedback depending on the distance that the user shared compared to the previous week.
  • The biggest change to this insight is I have removed the Google chart and now focus on contextual feedback with images related to the feedback being displayed. These are chosen at random so the user should get different feedback.
  • I have edited the InsightTerms class to be more accurate.

Thanks for all the feedback on this insight, hopefully you enjoy the changes as much as I have.

distancesharedv2

distancesharedv2image2

distancesharedv3image3

cdmoyer and others added 30 commits April 3, 2014 14:01
TODO:
* Redesign OSP admin views for plugins other than Facebook and Twitter
* Delete old dashboard and menu interfaces, classes, registrars, tests
* Add missing test coverage
* Clean up code
- URL-encode network username and network on insight headline links
- Show correct network icon for each insight
- Don't replace the colon in insight headlines
- Improve test coverage
Closes ThinkUpLLC#1809
When a non-logged-in user accesses an AuthController, redirect to the login page with a redirect GET parameter.
On login, redirect the user to that original URL.
Add Smarty plugin to custom URL encode network usernames with spaces and accented characters
ginatrapani and others added 2 commits June 16, 2014 14:32
…ombs

Insight fix: Don't show negative F-bombs
Nudges a user to post a photo if they haven't in the past week,
as long as they have in the past two weeks.

References ThinkUpLLC#1619
} elseif($mile_diff == 0) {
$threshold_string = "That's exactly the same as last week!";
} else {
$threshold_string = "That's still better then everyone who decided to stay on the couch.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this one, but we want "than", not "then". :)

@anildash
Copy link
Member

I really love the changes here -- seems like you nailed the spirit of the thing. Off to @ginatrapani for code review, because I think we're good on copy and images.

cdmoyer and others added 23 commits June 17, 2014 15:16
Simple Javascript tool to preview various headlines and bodies emebdded
in the html of an insight.
After a week since the last time the insight was generated,
if there are new memberships, any missed in the past week
are shown.

Also adds additional headline options.
…hip-repitition

Insight fix: Reduce group membership repetition
Insight fix: Fix singular like in weekly graph insight
…me-me-or-mi-mi-mi-do-re

Insight fix: Handle .me TLD more comprehensively in all about me
Closes ThinkUpLLC#1991
…ll-noisy

Stem Activity spike insight noise
Added config file, README docs for insight-html-to-server
…to-dislike-these-follower-count-tests

Use mktime to calculate relative months for follower count tests.
They're sort of faux-insights in a new template, for users on thinkup.com.

Copy fixes and code cleanup around the first run experience.
How often do you post super excitidely!!?!?!!?
Lets you know if you used exclamation points in the past 30
days.  Sometimes has a bar chart!!!
How often do you talk about the network on the network.

Closes ThinkUpLLC#1977, closes ThinkUpLLC#2011
Once, not 1 times, Punctuation and timing.
@gbrady92
Copy link
Contributor Author

Suggested changes have been made to this insight. Hopefully it is is good to go @cdmoyer .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants