1872 New Friend Links Insight. #2044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: * Redesign OSP admin views for plugins other than Facebook and Twitter * Delete old dashboard and menu interfaces, classes, registrars, tests * Add missing test coverage * Clean up code
…note in the footer
- URL-encode network username and network on insight headline links - Show correct network icon for each insight - Don't replace the colon in insight headlines - Improve test coverage Closes ThinkUpLLC#1809
When a non-logged-in user accesses an AuthController, redirect to the login page with a redirect GET parameter. On login, redirect the user to that original URL.
Add Smarty plugin to custom URL encode network usernames with spaces and accented characters
| $insight->slug = $slug; | ||
| $insight->instance_id = $instance->id; | ||
| $insight->date = $this->insight_date; | ||
| $person_text = count($users) > 1 ? 'people' : 'person'; |
There was a problem hiding this comment.
If there's only one person rather than multiple people, the headline should reference that specific person. Could be something like, "Did you see %person's website?" (And then be sure to set $insight->header_image to their avatar.)
|
A few comments on how copy could be improved are inline in the code. Overall, this is really good and a very useful insight! |
…onthly-insights Bonus magic day for monthly insights
…by limiting number of posts returned Plus some code cleanup
Instead of showing every amplifier today as it’s detected, show the single top amplified post from yesterday.
…heck for dupes to avoid repetition
…ogged out on thinkup.com
…riends bio and encourages user to follow them to get to know new friend.
ginatrapani
force-pushed
the
thinkup.com
branch
from
16b374f
to
461d9f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This insight checks to see if a user has new friends/followers/followees from the last week with links in their bios. If this criteria is met these links are displayed with their profile pictures in a list. The copy and the headline encourage the user to follow these links to get to know the person. The max number of users displayed is 3.