Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify aliasing #10

Closed
jimon opened this issue Oct 15, 2016 · 2 comments
Closed

Clarify aliasing #10

jimon opened this issue Oct 15, 2016 · 2 comments

Comments

@jimon
Copy link
Contributor

jimon commented Oct 15, 2016

There are tons of functions in gb_math with declaration similar to gb_mat4_mul(gbMat4 *out, gbMat4 *m1, gbMat4 *m2). Would be nice to have a clarification if out can point to either of inputs or not. Because looks like most of functions are safe to use when we reuse one of inputs as output, but I'm not 100% sure :)
@gingerBill
Copy link
Owner

I'm not overly concerned about specifying the aliasing. If I want to specify that they don't alias, I would use restrict so I think it's okay to assume that they can without restrict.

@jimon
Copy link
Contributor Author

jimon commented Oct 16, 2016

Ah ok, I see you have on stack buffers in place to accommodate aliasing case 👍

@jimon jimon closed this as completed Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimon @gingerBill