Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep benchmarking errors #171

Open
gflegar opened this issue Dec 3, 2018 · 0 comments
Open

Keep benchmarking errors #171

gflegar opened this issue Dec 3, 2018 · 0 comments
Labels
is:enhancement An improvement of an existing feature. is:good-first-issue Good for newcomers. is:help-wanted Need ideas on how to solve this. reg:benchmarking This is related to benchmarking.

Comments

@gflegar
Copy link
Member

gflegar commented Dec 3, 2018

Currently, we're dropping all the errors that happen in the benchmarks.

The run_all_benchmarks.sh script redirects all the stderr output from benchmark runners to stdout, and the stdout of run_all_benchmarks.sh is redirected to /dev/null in the CMake target for running the benchmarks (defined in benchmark/CMakeLists.txt). Instead, we should create a temporary file and redirect the output there.

@gflegar gflegar added is:enhancement An improvement of an existing feature. reg:benchmarking This is related to benchmarking. labels Dec 3, 2018
@tcojean tcojean added the is:good-first-issue Good for newcomers. label Dec 6, 2018
@tcojean tcojean added the is:help-wanted Need ideas on how to solve this. label Nov 14, 2019
@upsj upsj added this to the Ginkgo 1.5.0 milestone May 7, 2021
@upsj upsj removed this from the Ginkgo 1.5.0 milestone Nov 2, 2022
@upsj upsj added this to To do in Release 1.6.0 via automation Nov 2, 2022
@upsj upsj moved this from To do to Low Priority in Release 1.6.0 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:enhancement An improvement of an existing feature. is:good-first-issue Good for newcomers. is:help-wanted Need ideas on how to solve this. reg:benchmarking This is related to benchmarking.
Projects
None yet
Development

No branches or pull requests

3 participants