Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependence on six library #8

Closed
wants to merge 1 commit into from
Closed

Removed dependence on six library #8

wants to merge 1 commit into from

Conversation

al42and
Copy link

@al42and al42and commented Jan 3, 2013

Currently, picklefield requires six for singe one-line function with_metaclass.

I'm not sure whether such change is desirable, but I think removing nearly-unnecessary dependency might be convenient.

@budlight
Copy link

I'm sure the reason he requires six is to eventually make it python 2 and 3 compatible. This sounds like going backwards.

@rafales
Copy link

rafales commented Jan 30, 2013

@budlight it is python 3 compatible. If you encountered any bugs while using picklefield with python 3 then please fill a bug report.

@budlight
Copy link

@rafales sorry you thought I was saying it wasn't python 3 compatible, but it wasn't my place to flat out say it is, because I had never tried it.

@tacaswell
Copy link

It looks like the current version of django ships with it's own copy of six, if any change should be made it is to import from django's version from django.utils import six.

six is more-or-less a must-have library anyway so I don't see the benefit of this.

@charettes
Copy link
Collaborator

I agree with @tacaswell that we should import six from django.utils instead. Will submit a PR with the required changes.

@charettes charettes closed this in 7ec0333 Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants