Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scalability #6

Closed
splitice opened this issue Aug 23, 2021 · 3 comments
Closed

Scalability #6

splitice opened this issue Aug 23, 2021 · 3 comments

Comments

@splitice
Copy link

On review I noticed this module is prone to poor scalability.

Scales roughly O(n*m) where n is the number of languages supplied in the header and m is the number of languages supported.

If m is sufficiently large this module will cease to perform well.
@giom
Copy link
Owner

giom commented Aug 23, 2021

Hi, you're probably right, I only ever used it with m = 3 languages. I do not currently use this module since we switched to using a CDN in front of nginx for the use case I had and we now do the normalization in the CDN. However, I will spend time to clean up and look at any PR this week.

@splitice
Copy link
Author

@giom I think replacing the array with a ngx_hash_t would work.

@splitice
Copy link
Author

Closing in favor of #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giom @splitice