Improving tests (date and tidy-service) #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2015 12:48
…ents. Currently if the php timezone is defined as anything not UTC the date test will fail.
fixed an edge case for adding '...' for when the content was the exact length of the limit
|
Is tidy enabled by default on Travis? |
|
Looks like it, travis doesn't error out and the coverage shows it skips right over that check https://coveralls.io/builds/3613775/source?filename=src%2Fservices%2Ftidy-service.php#L28 I got one more test case to add before we merge this in.. |
idmontie
added a commit
that referenced
this pull request
Sep 18, 2015
Improving tests (date and tidy-service)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved test coverage for tidy-service.
The timezone specification should be in all php setups, however if you happen to have it set to not UTC you get a test failure because the date() will convert to whatever the local timezone is.