Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurlDownload fails in Windows #1

Closed
noetix opened this issue Jan 5, 2014 · 2 comments
Closed

CurlDownload fails in Windows #1

noetix opened this issue Jan 5, 2014 · 2 comments

Comments

@noetix
Copy link

noetix commented Jan 5, 2014

Test cases on Windows:

PHPUnit 3.7.28 by Sebastian Bergmann.

Configuration read from C:\Escapee\src\Giosh94mhz\GeonamesBundle\phpunit.xml.dist

..............FSSF........

Time: 728 ms, Memory: 4.75Mb

There were 2 failures:

1) Giosh94mhz\GeonamesBundle\Tests\Utils\CurlDownloadTest::testDownload
Failed asserting that 0 is greater than 0.

C:\Escapee\src\Giosh94mhz\GeonamesBundle\Tests\Utils\CurlDownloadTest.php:77

2) Giosh94mhz\GeonamesBundle\Tests\Utils\CurlDownloadTest::testMultiDownload
Failed asserting that 0 is greater than 0.

C:\Escapee\src\Giosh94mhz\GeonamesBundle\Tests\Utils\CurlDownloadTest.php:145

FAILURES!
Tests: 24, Assertions: 130, Failures: 2, Skipped: 2.

Test cases on Linux:

PHPUnit 3.6.4 by Sebastian Bergmann.

Configuration read from /root/GeonamesBundle/phpunit.xml.dist

..........................

Time: 3 seconds, Memory: 3.25Mb

OK (26 tests, 135 assertions)

I've had a quick look through CurlDownload but I can't see what's doing it.

@giosh94mhz
Copy link
Owner

Sorry closed by mistake.

Supporting windows is really hard for me, since the only system I use are UNIX based. Anyway improvements are always welcome!

The failed tests try to download pages from http://www.example.com/something , so the failure can be related to CURL functions under Windows or connectivity issues.

@giosh94mhz giosh94mhz reopened this Jan 8, 2014
@giosh94mhz
Copy link
Owner

The Bundle now support Guzzle as a download adapter, so there is no need to support Windows in CurlDownloder anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants