Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heuristic for scanning formulas is faulty #45

Closed
vstange opened this issue Dec 29, 2017 · 7 comments
Closed

Heuristic for scanning formulas is faulty #45

vstange opened this issue Dec 29, 2017 · 7 comments
Assignees

Comments

@vstange
Copy link
Member

vstange commented Dec 29, 2017

The scanFormulaNode can't recognize formulas not containing "apply"- or "mrow"-nodes. The mistake is based on my false assumption that there should always be a surrounding element.

Instead, the method should examine the semantic elements more closely.

@physikerwelt
Copy link
Member

@AndreG-P did you already solve this problem. I vaguely remember that you had a similar issue?

@AndreG-P
Copy link
Member

AndreG-P commented Jan 4, 2018

Actually, you did... It was a bug in vmext: gipplab/vmext#23

@physikerwelt
Copy link
Member

@vstange
Copy link
Member Author

vstange commented Feb 19, 2018

Noted.

@physikerwelt
Copy link
Member

can this ticket be closed @vstange ?

@physikerwelt physikerwelt transferred this issue from gipplab/MathMLConverters Nov 30, 2020
@physikerwelt physikerwelt assigned AndreG-P and unassigned vstange Nov 30, 2020
@AndreG-P
Copy link
Member

@physikerwelt I'm not sure what the problem is. The code already inspects nodes more closely based on
https://github.com/ag-gipp/MathMLTools/blob/00c269d0c313b317a5b5333434b6983157461a11/mathml-converters/src/main/java/com/formulasearchengine/mathmltools/converters/MathMLConverter.java#L232-L245

For vmext you implemented:

    const content = this.select('//m:annotation-xml[@encoding="MathML-Content"]', this.doc, true);
    if (!content) {
      throw new Error("No content MathML present");
    }
    return this.parseApply(content.firstChild);

As you can see, the method above already checks the same information. So either you can tell me what is broken or give me an example that does not work.

@physikerwelt
Copy link
Member

It is probably an old issue that had been resolved before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants