-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heuristic for scanning formulas is faulty #45
Comments
@AndreG-P did you already solve this problem. I vaguely remember that you had a similar issue? |
Actually, you did... It was a bug in vmext: gipplab/vmext#23 |
@vstange can you follow the approach from https://github.com/ag-gipp/vmext/pull/25/files#diff-c9cf159d96357b7583ac5bc9f33564adR45 |
Noted. |
can this ticket be closed @vstange ? |
@physikerwelt I'm not sure what the problem is. The code already inspects nodes more closely based on For vmext you implemented: const content = this.select('//m:annotation-xml[@encoding="MathML-Content"]', this.doc, true);
if (!content) {
throw new Error("No content MathML present");
}
return this.parseApply(content.firstChild); As you can see, the method above already checks the same information. So either you can tell me what is broken or give me an example that does not work. |
It is probably an old issue that had been resolved before |
The
scanFormulaNode
can't recognize formulas not containing "apply"- or "mrow"-nodes. The mistake is based on my false assumption that there should always be a surrounding element.Instead, the method should examine the semantic elements more closely.
The text was updated successfully, but these errors were encountered: