New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rasterio source #927
Rasterio source #927
Conversation
but I prefer black
the use og gdal-style transform is depcrecated since rasterio 1.0
assert image != image2 | ||
|
||
|
||
def testPixel(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manthey, I think I'll need some support satrting from here, I cannot manage to make the test to work and it's coming from outside of the actual source file so I think I'll loose my time trying to understand what's wrong.
When I run the test for test/test_source_rasterio.py::testPixel, I always get an empty rgb values. could you have a look ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you open a sample file (e.g., test/test_files/rgb_geotiff.tiff) without a projection and then call getThumbnail, you'll see that returns an all black result. getPixel is just the victim of this... I haven't looked into what is happening without a projection yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm,I need to check then, because when I was looking at the generated jpeg it seemed to me that it was working
No worries, @12rambau! enjoy some time away from the keyboard! Thank you for getting so far along in this PR -- @manthey and I should be able to wrap it up and merge it soon here (perhaps not in a perfect state, but far enough that this source can be used downstream and make the installation process much easier) |
Fix #898
at the moment this is just to show that I'm moving forward.
I think I still missed some very specific tricks with projections but we are getting there. If you want to have a look be my guest, I still need to test it but that's complicated in my environment.