Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks disappear when we change collections of a dashboard #719

Closed
MohamedHamouGisaia opened this issue Jan 5, 2024 · 0 comments · Fixed by #790
Closed

Bookmarks disappear when we change collections of a dashboard #719

MohamedHamouGisaia opened this issue Jan 5, 2024 · 0 comments · Fixed by #790
Assignees
Labels
type:bug Something isn't working
Milestone

Comments

@MohamedHamouGisaia
Copy link
Member

MohamedHamouGisaia commented Jan 5, 2024

When we create a bookmark, in persitence we store a Bookmark object containing, among other attributes,

  • filters
  • collections

The collections attribute is the concatenation of all collections available in the dashboard (whether a filter is applied on a collection or not)

On the other hand, in ARLAS-wui, on a given dashbord, let's name it D, when we want to display the list of available bookmarks, only bookmarks with collections attribute having the same collections of the dashboard D are shown.

This means that if later on we add a new widget to D, that belongs to a yet a new collection, those same bookmarks won't display anymore.

We need to decide how to handle this properly

One of the possible approaches is to display the bookmark as long as the collections of filters attributes are all available in the dashboard.

@MohamedHamouGisaia MohamedHamouGisaia added this to the 24.3.5 milestone Jan 5, 2024
@MohamedHamouGisaia MohamedHamouGisaia added type:enhancement Feature that impacts end-user iam labels Jan 5, 2024
@MohamedHamouGisaia MohamedHamouGisaia changed the title Store the bookmark id in the config.json Filter bookmark list by organisation Jan 12, 2024
@MohamedHamouGisaia MohamedHamouGisaia self-assigned this Jan 12, 2024
@MohamedHamouGisaia MohamedHamouGisaia modified the milestones: 24.3.5, 25.0.0 Feb 16, 2024
@MohamedHamouGisaia MohamedHamouGisaia added type:question Further information is requested type:bug Something isn't working and removed type:enhancement Feature that impacts end-user iam labels Feb 22, 2024
@MohamedHamouGisaia MohamedHamouGisaia changed the title Filter bookmark list by organisation Bookmarks disappear when we change Feb 22, 2024
@MohamedHamouGisaia MohamedHamouGisaia changed the title Bookmarks disappear when we change Bookmarks disappear when we change collections of a dashboard Feb 22, 2024
@MohamedHamouGisaia MohamedHamouGisaia modified the milestones: 25.0.0, 25.0.1 Mar 15, 2024
@MohamedHamouGisaia MohamedHamouGisaia removed their assignment Apr 22, 2024
@MohamedHamouGisaia MohamedHamouGisaia self-assigned this May 15, 2024
@MohamedHamouGisaia MohamedHamouGisaia removed the type:question Further information is requested label May 15, 2024
@MohamedHamouGisaia MohamedHamouGisaia modified the milestones: 25.0.1, 25.0.0 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant