Added logger on listener output instead of returns

gisce · Nov 9, 2016 · d300a96 · d300a96
1 parent ff11d51
commit d300a96
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/hookshub/listener.py b/hookshub/listener.py
@@ -8,6 +8,7 @@
 import json
 import tempfile
 import shutil
+import logging
 
 
 class TempDir(object):
@@ -38,6 +39,7 @@ def instancer(payload):
             return github(payload)
 
     def run_event_actions(self, config_file):
+        logger = logging.getLogger('__main__')
         def_conf = {}
 
         with open(config_file, 'r') as config:
@@ -52,11 +54,11 @@ def run_event_actions(self, config_file):
 
         hook = self.instancer(self.payload)
         i = 0
-        log = 'Executed {} actions\n'.format(len(hook.event_actions))
+        logger.info('Executing {} actions\n'.format(len(hook.event_actions)))
 
         for action in hook.event_actions:
             i += 1
-            log += ('[Running: <{0}/{1}> - {2}]\n'.format(
+            logger.info('[Running: <{0}/{1}> - {2}]\n'.format(
                 i, len(hook.event_actions), action)
             )
             args = hook.get_exe_action(action, conf)
@@ -75,11 +77,13 @@ def run_event_actions(self, config_file):
                     action, stderr
                 ))
                 if proc.returncode != 0:
-                    log += ('[{0}]:{1}\n[{0}]:Failed!\n'.format(
+                    log = ('[{0}]:{1}\n[{0}]:Failed!\n'.format(
                         action, output
                     ))
+                    logger.error(log.replace('|', '\n'))
                     return -1, log
-                log += ('[{0}]:{1}\n[{0}]:Success!\n'.format(
+                log = ('[{0}]:{1}\n[{0}]:Success!\n'.format(
                     action, output
                 ))
+                logger.info(log.replace('|', '\n'))
         return 0, log