Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The hidden class is not added to the gsc-timeline element when there are no comments. #1145

Closed
flamecommit opened this issue Aug 11, 2023 · 3 comments · Fixed by #1151
Closed

The hidden class is not added to the gsc-timeline element when there are no comments. #1145

flamecommit opened this issue Aug 11, 2023 · 3 comments · Fixed by #1151

Comments

@flamecommit
Copy link

image

I want to know why the hidden class is not added to the gsc-timeline element.
@flamecommit
Copy link
Author

It seems to be a phenomenon that occurs before 'Discussions' are automatically generated.
image

@laymonage laymonage mentioned this issue Aug 12, 2023
Merged
@laymonage
Copy link
Member

Thank you, fixed.

@flamecommit
Copy link
Author

@laymonage Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix timeline element not being hidden when the discussion hasn't been created giscus/giscus
2 participants
@laymonage @flamecommit