Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused CSS variables #48

Closed
laymonage opened this issue May 5, 2021 · 0 comments · Fixed by #135
Closed

Drop unused CSS variables #48

laymonage opened this issue May 5, 2021 · 0 comments · Fixed by #135
Labels
decision needed Needs considerations before implementing enhancement Nice to have

Comments

@laymonage
Copy link
Member

I'm just copying the variables from @primer/primitives and GitHub's website. There are a lot of unused variables in the current theme files. It would be nice if we could remove them at build time. I tried using PurgeCSS but I couldn't find the right configuration that plays well with the project's setup.

If the only option is to trim down the theme files, I'm also okay with it, as long as it's easy enough to re-add any variables that we need in the future.

@laymonage laymonage added decision needed Needs considerations before implementing enhancement Nice to have labels May 5, 2021
@laymonage laymonage mentioned this issue May 5, 2021
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decision needed Needs considerations before implementing enhancement Nice to have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant