Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "edit" menu or direct link to the connected Discussion topic #630

Open
expikr opened this issue Jul 29, 2022 · 4 comments
Open

Add an "edit" menu or direct link to the connected Discussion topic #630

expikr opened this issue Jul 29, 2022 · 4 comments

Comments

@expikr
Copy link

expikr commented Jul 29, 2022

The original Discussions page has a hamburger menu for basic actions such as editing and deleting:

image

Whereas giscus is missing the UI entirely:

image

Would it be feasible to update the UI to reflect how it works on GitHub? Or as a stopgap measure, there could just be a direct link to the connected Discussions section on GitHub, which also have the benefit of making it quicker to moderate the section as a site owner.

@expikr expikr changed the title Add "edit" hamburger menu or a shortcut pointing to the linked discussion Add an "edit" menu/link to the connected Discussion topic Jul 29, 2022
@expikr expikr changed the title Add an "edit" menu/link to the connected Discussion topic Add an "edit" menu or direct link to the connected Discussion topic Jul 29, 2022
@laymonage
Copy link
Member

The timestamp is a link to the comment on GitHub. The "X comments/Y reactions" is also a link to the discussion on GitHub.

The pop-up menu is #36.

@expikr
Copy link
Author

expikr commented Jul 29, 2022

Oh, interesting. I think it would be a bit more discoverable if the "powered by giscus" line have something visibly clickable appended to it, like "View Discussion on GitHub" or something along those lines.

And perhaps before #36 is implemented, there could be a placeholder menu that just says "Edit on GitHub" when clicked.

image

@FarisZR
Copy link

FarisZR commented Aug 8, 2022

Yeah, I also couldn't find any direct link to The GitHub discussion easily.
It would be great for people who don't want to authenticate their accounts, maybe a gray button beside sign with GitHub, “comment on the discussion manually”

@ryanwwest
Copy link

The timestamp is a link to the comment on GitHub. The "X comments/Y reactions" is also a link to the discussion on GitHub.

The pop-up menu is #36.

I'm curious how feasible it would be to have a similar link to each comment on the blog page. Maybe the URL path could partially match the corresponding link to take you directly to the Github discussion page, but it might be nice to allow for link sharing directly to the blog post if there's an interesting comment buried in the thread; the experience isn't quite as nice when you don't have the blog to check out on the same page in Github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants