Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple cascading search #72

Open
sirinath opened this issue May 15, 2021 · 1 comment
Open

Multiple cascading search #72

sirinath opened this issue May 15, 2021 · 1 comment
Labels
enhancement Nice to have someday/maybe Cannot be decided at the moment.

Comments

@sirinath
Copy link

Add the ability to have multiple search criteria like data-mapping="title|og:title". The page actually created automatically would be according to 1st criterial in the list.

In case one changes the criteria later, the conversations will not get unlinked from the page.

@laymonage laymonage added decision needed Needs considerations before implementing enhancement Nice to have labels May 15, 2021
@laymonage
Copy link
Member

Thanks for the suggestion, but I'm still not sure about this. This means we'd have to pass all of the page's attributes to the widget.

To be honest, users can solve this manually by just renaming the existing discussions' titles to reflect the new mapping. It might be a bit of a heavy task if you've got a lot of discussions, but you can also write a script for that.

If someone comes up with a PR, I'll consider it.

@laymonage laymonage added someday/maybe Cannot be decided at the moment. and removed decision needed Needs considerations before implementing labels Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Nice to have someday/maybe Cannot be decided at the moment.
Projects
None yet
Development

No branches or pull requests

2 participants