Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Issue(Crash) #2

Closed
Ace8Underscore opened this issue May 29, 2020 · 2 comments
Closed

Settings Issue(Crash) #2

Ace8Underscore opened this issue May 29, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Ace8Underscore
Copy link

After messing around with the code I’ve noticed if making a setting in a pre-existing module will result in a game crash leaving me to having to delete the config so the config will be generated with the Boolean setting and not crash. I’ve noticed that if I do continue to change version numbers for my public releases the users won’t notice this but, this would lead them to getting a config that has been reset every next update. Also I’ve noticed it does slow me down in testing it in my ide. I have just made the config reset/generate on launch for easy testing so this config doesn’t slow me down much. Is there anyway to make the client not have this problem when having new settings/hacks? Possibly once the client start it checks if it needs to write any new hacks/settings to the config. I tried to do this but failed because of my lack of java skill.

@Ace8Underscore
Copy link
Author

Other than those issues this is a great client and am thinking of contributing to it :D. Great work!

@GishReloaded
Copy link
Owner

It is should to make a function that will be called before loading data from the config. It will compare the hacks that are in the config with those that your client downloaded, if hack not found, add new lines to the config. Thanks you for issue. It will be fixed in the next update.

@GishReloaded GishReloaded added the bug Something isn't working label Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants