Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address JOSS reviewer comments #83

Closed
giswqs opened this issue Jul 11, 2021 · 1 comment
Closed

Address JOSS reviewer comments #83

giswqs opened this issue Jul 11, 2021 · 1 comment
Assignees
@giswqs
Labels
enhancement New feature or request
Projects
leafmap

Comments

@giswqs
Copy link
Member

giswqs commented Jul 11, 2021 •
edited

This issue is for addressing the JOSS reviewer comments:
@giswqs giswqs added the enhancement New feature or request label Jul 11, 2021
@giswqs giswqs self-assigned this Jul 11, 2021
@giswqs giswqs added this to To do in leafmap via automation Jul 11, 2021
giswqs added a commit that referenced this issue Jul 12, 2021
@giswqs
Added citations #83
fe3272d
giswqs added a commit that referenced this issue Jul 12, 2021
@giswqs
Made XYZ tiles attribution required #83
ad6b0d1
giswqs added a commit that referenced this issue Jul 13, 2021
@giswqs
Changed some functions to be private #83
a28e84a
giswqs added a commit that referenced this issue Jul 13, 2021
@giswqs
Fixed docs biuld error #83
cdb302e
giswqs added a commit that referenced this issue Jul 14, 2021
@giswqs
Added more info about plotting backends #83
4aecff2
giswqs added a commit that referenced this issue Jul 14, 2021
@giswqs
Added text description to notebooks #83
7b677f5
@giswqs giswqs mentioned this issue Jul 14, 2021
Closed
40 tasks
@giswqs giswqs moved this from To do to In progress in leafmap Jul 14, 2021
giswqs added a commit that referenced this issue Jul 14, 2021
@giswqs
Added NotImplementedError for foliumap #83
c2df275
giswqs added a commit that referenced this issue Jul 15, 2021
@giswqs
Added text description to notebooks #83
2c8f328
giswqs added a commit that referenced this issue Jul 15, 2021
@giswqs
Fixed typos using codespell #83
543c884
giswqs added a commit that referenced this issue Jul 17, 2021
@giswqs
Added text description to notebooks #83
d05205d
giswqs added a commit that referenced this issue Jul 17, 2021
@giswqs
Added Code of Conduct #83
4a178ec
giswqs added a commit that referenced this issue Jul 17, 2021
@giswqs
Made usage page interactive #83
8f5ae63
giswqs added a commit that referenced this issue Jul 17, 2021
@giswqs
Added key features notebook #83
c4e5b3d
giswqs added a commit that referenced this issue Jul 18, 2021
@giswqs
Improved key features notebook #83
f1bf297
giswqs added a commit that referenced this issue Jul 18, 2021
@giswqs
Added plotting backend comparison #83
ae10e10
giswqs added a commit that referenced this issue Jul 20, 2021
@giswqs
Added leafmap and foliumap unittest #83
a1417d5
giswqs added a commit that referenced this issue Jul 21, 2021
@giswqs
Fixed unittest error #83
6ef11cf
giswqs added a commit that referenced this issue Jul 21, 2021
@giswqs
Improved JOSS paper #83
0467cdd
giswqs added a commit that referenced this issue Jul 21, 2021
@giswqs
Improved README #83
464856e
giswqs added a commit that referenced this issue Jul 24, 2021
@giswqs
Added unittest for toolbar module #83
5eef1bd
giswqs added a commit that referenced this issue Jul 24, 2021
@giswqs
Fixed docs build error #83
b0645c9
@giswqs
Copy link
Member Author

giswqs commented Jul 27, 2021

All reviewers' comments have been addressed. The paper has been published at https://doi.org/10.21105/joss.03414

@giswqs giswqs closed this as completed Jul 27, 2021
leafmap automation moved this from In progress to Done Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giswqs giswqs

Labels
enhancement New feature or request
Projects
leafmap
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@giswqs