Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"min_depth" parameter ignored in Depression/level_set method #25

Open
geotom opened this issue May 12, 2022 · 2 comments
Open

"min_depth" parameter ignored in Depression/level_set method #25

geotom opened this issue May 12, 2022 · 2 comments

Comments

@geotom
Copy link

geotom commented May 12, 2022

  • lidar version: 0.6.1
  • Python version: 3.8
  • Operating System: Ubuntu

Description

I noticed that the minimum depth parameter is ignored when delineating depressions with lidar. I checked the code and this seems to be the case for

DelineateDepressions(in_sink, min_size, min_depth, interval, out_dir, bool_level_shp=False)

See: https://github.com/giswqs/lidar/blob/66498a36c4eb184d00bc4cce3ee41de86f53a4cb/lidar/slicing.py#L570

@giswqs
Copy link
Member

giswqs commented May 19, 2022

I will look into this when I have time. Pull request is welcome if you figure out how to solve the issue.

@ajinra020307
Copy link

i am facing this same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants