Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automatic link for gitlab merge requests #160

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

barryib
Copy link
Contributor

@barryib barryib commented Jul 8, 2021

What does this do / why do we need it?

This will add link for merge requests for gitlab style. See #159 for more details.

How this PR fixes the problem?

It follow gitlab merge request links standards.

Check lists

  • Test passed
  • Coding style (indentation, etc)

Which issue(s) does this PR fix?

fixes #159

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1011881492

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 76.808%

Totals Coverage Status
Change from base Build 1000413462: 0.04%
Covered Lines: 1848
Relevant Lines: 2406

💛 - Coveralls

@barryib
Copy link
Contributor Author

barryib commented Jul 8, 2021

Adding @khos2ow @mavogel as reviewers

@mavogel mavogel self-requested a review July 8, 2021 15:20
@mavogel mavogel requested a review from clok July 8, 2021 15:20
@mavogel mavogel merged commit 21b98bd into git-chglog:master Jul 9, 2021
@dbluxo
Copy link

dbluxo commented Sep 22, 2021

Is there anything special that needs to be activated? I have selected the gitlab style, but the merge requests do not appear as links, but only as follows:

<a name="2021.09.22"></a>
## [2021.09.22] - 2021-09-22
### Merge Requests
- Merge branch 'renovate/aws-ebs-csi-driver-2.x' into 'main'
- Merge branch 'renovate/aws-ebs-csi-driver-2.x' into 'main'
- Merge branch 'renovate/aws-ebs-csi-driver-2.x' into 'main'
- Merge branch 'renovate/cluster-autoscaler-9.x' into 'main'
- Merge branch 'renovate/cluster-autoscaler-9.x' into 'main'
- Merge branch 'renovate/kubernetes-dashboard-5.x' into 'main'
- Merge branch 'renovate/kubernetes-dashboard-4.x' into 'main'
- Merge branch '38-add-correct-tags-to-ebs-pvcs' into 'main'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add correct links for gitlab merge requests
5 participants