Selected file item in "status" list jumps randomly

[AndiDog]

Using Windows 7, git-cola 1.7.5. The problem occurred already with v1.7.4 after I used it without problems for a while. Now I always get this problem with one repo.

When I select a file under "Modified" (or "Untracked", doesn't matter), the selection jumps to another element after a second or it gets deselected. Unfortunately I can reproduce this only with one of my Git repos (a confidential one), not with the others. Looks like a directory monitoring issue to me that always updates the list. Also killed TGitCache but no difference.

Do you have an idea, or a hint where in the source code I should start debugging?

[davvid]

Interesting. If you're on Windows then the directory monitoring happens in cola/inotify.py's run_win32() method.

Right now we have Linux inotify and Win32 monitoring handled in a single file. I think we'll probably want to break these apart into separate files to keep things easier to maintain in the long run.

An easy way to disable it is to return immediately from the start() function. If this fixes the problem for you then we'll have to loop in @kbielefe who is the original author of the win32 directory monitoring.

BTW, does this repo happen to be a submodule, or does it use a .git file (instead of a .git directory)? I ask because I noticed that the win32 monitoring checks for if not path.startswith('.git/') ... to detect whether the file in question is beneath the .git/ directory. Repos with .git files (newer submodules, for example) may not be properly detected by this test. But, I'm not very familiar with the win32 side so I'll defer to kbielefe who knows better than I.

Thanks for the heads-up.

[AndiDog]

Thanks for telling me where to look. I actually found that the problem is the line you mentioned in run_win32. For me, it handles a file in the .git directory of a submodule, e.g. path == 'lib-src/ServiceStack/.git/index.lock'. The following change fixes that:

if not path.startswith('.git/') and "/.git/" not in path and os.path.isfile(path):

[davvid]

Awesome, I'm glad that worked. I'd like to credit you with this change. Do you mind if I make a commit with you as the author?

[AndiDog]

That's fine with me, thanks for resolving!