Commit message editor lies about line breaking when a line is prefixed with "Word: "

[ghost]

I tested the following: start the first line of the commit message body (i.e. not the subject) with something like Word: bla bla...., and make that more than 80 characters. The commit message editor will display the text as line-broken. So far this is exactly as expected.

Then press the commit button, and inspect the commit log with some other tool, like git log. You will find that the commit message wasn't actually line-broken, and doesn't contain any line breaks.

If you add a second paragraph (that doesn't contain any :), this paragraph will still be line-broken correctly.

Observed with git-cola v2.0.1 (debian unstable package).

[davvid]

Yeah.. this is cos we interpret those as special tags that shouldn't be wrapped. e.g. Signed-off-by:, Tested-by:, Reported-by:, etc. in cola/textwrap.py

# Acked-by:, Signed-off-by:, Helped-by:, etc.
special_tag_rgx = re.compile('^[a-zA-Z_-]+:')

The heuristic is probably too greedy right now. If possible, it'd be better to explicitly list the ones tags that it should special-case (and maybe later add a config knob to allow us to extend them) rather than assuming that all foo: lines shouldn't be wrapped.