New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to run git-cola if the install prefix contains non-ASCII characters #276

Closed
Vdragon opened this Issue Jun 6, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@Vdragon
Contributor

Vdragon commented Jun 6, 2014

Yeah, another Unicode issue :)
I wonder it's fixable in git-cola...

Reproduce steps

$ make
$ make prefix=build/軟體/git-cola install
$ build/軟體/git-cola/bin/git-cola

Traceback

Traceback (most recent call last):
  File "./bin/git-cola", line 47, in <module>
    setup_environment()
  File "./bin/git-cola", line 39, in setup_environment
    cola_mod = os.path.join(prefix, 'cola', '__init__.py')
  File "/usr/lib/python2.7/posixpath.py", line 83, in join
    path += '/' + b
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe8 in position 98: ordinal not in range(128)

Environment

OS

Ubuntu 14.04LTS x86 64bit

Python

2.7.5 from Ubuntu repo

Locale

zh_TW.UTF-8

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jun 7, 2014

Member

Fixed in 8fcc96d

Member

davvid commented Jun 7, 2014

Fixed in 8fcc96d

@davvid davvid closed this Jun 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment