Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-D no longer works (Fedora 21, git-cola 2.1.2) #456

Closed
WanWizard opened this issue May 20, 2015 · 0 comments
Closed

Ctrl-D no longer works (Fedora 21, git-cola 2.1.2) #456

WanWizard opened this issue May 20, 2015 · 0 comments
Labels

Comments

@WanWizard
Copy link

Problem is that https://github.com/git-cola/git-cola/blob/master/cola/cmds.py#L815 constructs an incorrect shell command.

It creates gnome-terminal -e git mergetool --no-prompt ... which fails with the error Failed to parse arguments: Unknown option --no-prompt because it sees the --no-prompt argument as part of gnome-terminal, and not of git.

The fixed xterm -e used in previous versions doesn't have this problem, which might be a reason why it hasn't been spotted before.

@Vdragon Vdragon added the bug label May 20, 2015
@davvid davvid closed this as completed in f1316dc May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants